Fix coordinate parsing for events datafix: harden coordinate parsing and add tests#7
Open
AhmedAli58 wants to merge 1 commit intoAeroPython:masterfrom
Open
Fix coordinate parsing for events datafix: harden coordinate parsing and add tests#7AhmedAli58 wants to merge 1 commit intoAeroPython:masterfrom
AhmedAli58 wants to merge 1 commit intoAeroPython:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: convert_lat and convert_lon can raise TypeError or IndexError for None, short, or malformed inputs, causing event loading to fail.
Solution: Introduce centralized coordinate parsing with input validation, safe fallback to np.nan, and debug logging for invalid inputs.
Tests: PYTHONPATH=. pytest
Compatibility: No breaking changes. Invalid inputs still resolve to np.nan, now without crashes.