Skip to content

Fix pressing submit button not submitting results for processing#85

Merged
AlexJSully merged 3 commits intomasterfrom
alexjsully-260218-fix-submit-button-not-working
Feb 19, 2026
Merged

Fix pressing submit button not submitting results for processing#85
AlexJSully merged 3 commits intomasterfrom
alexjsully-260218-fix-submit-button-not-working

Conversation

@AlexJSully
Copy link
Owner

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a broken submission/marking flow by fixing the gRNA answer-checking logic and adding Playwright E2E coverage to ensure clicking Submit results in scoring + feedback being rendered.

Changes:

  • Fix checkAnswers() logic to use the correct matched answer object when computing score thresholds.
  • Add Playwright E2E tests covering the end-to-end submission flow and expected scores.
  • Update test script names/docs/workflow wiring; adjust Sentry init usage and update generated service worker artifacts.

Reviewed changes

Copilot reviewed 12 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
core/scripts/crispr_scripts.js Fixes a logic/indexing error in checkAnswers() by referencing the current matched answer object (possibleAnswer).
core/scripts/crispr_scripts.min.js Updates the minified bundle to include the same submission/marking fix.
tests/playwright/submission.spec.js Adds E2E tests verifying that Submit triggers marking + feedback and produces expected scores.
playwright.config.js Updates device list and changes retry/worker configuration (now hard-coded).
package.json Renames Playwright scripts to test:e2e:* and updates validate to call the renamed script.
docs/guides/setup.md Updates documentation to match renamed E2E scripts and lists the new submission test file.
.github/workflows/code-qa.yaml Updates CI to run the renamed E2E script.
index.html / core/systemrun.html Updates Sentry integration initialization usage and removes tracing configuration.
eslint.config.js Ignores generated Playwright artifacts (playwright-report, test-results).
core/scripts/serviceWorker/sw.js / sw.js.map Updates generated service worker + source map outputs (precache URLs and embedded paths changed).
core/scripts/runtime.test.js Removes some parameterized/integration test coverage for runtime flow initialization.
core/scripts/crispr_scripts.test.js Adds an additional unit test case for createComplementarySeq() related to eBFP inputs.
package-lock.json Lockfile updates corresponding to dependency bumps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AlexJSully AlexJSully merged commit 190cb2e into master Feb 19, 2026
6 checks passed
@AlexJSully AlexJSully deleted the alexjsully-260218-fix-submit-button-not-working branch February 19, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants