Skip to content

Fixed unable to click the submit button again#86

Merged
AlexJSully merged 4 commits intomasterfrom
alexjsully-260219-fixed-unable-to-press-the-submit-button-again
Feb 19, 2026
Merged

Fixed unable to click the submit button again#86
AlexJSully merged 4 commits intomasterfrom
alexjsully-260219-fixed-unable-to-press-the-submit-button-again

Conversation

@AlexJSully
Copy link
Owner

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the SciGrade submission/feedback UX to remove the Bootstrap modal-based feedback flow and render feedback inline via showFeedback(), with supporting doc updates and regenerated static assets.

Changes:

  • Remove feedback modal markup from core/systemrun.html and stop triggering it from submitAnswers().
  • Update feedback UI collapse markup for Bootstrap 5 (data-bs-*) in showFeedback() and the minified bundle.
  • Update Playwright configuration and E2E test timing; refresh Workbox service worker artifacts and docs to match the new feedback flow.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
tests/playwright/submission.spec.js Adds an extra wait after form render (currently via fixed timeout).
playwright.config.js Reduces Playwright worker count.
docs/index.md Documents that feedback is rendered inline by showFeedback().
docs/architecture/index.md Updates architecture docs to reflect inline feedback UI (no modal).
core/systemrun.html Removes the feedback modal/button markup from the runtime page.
core/scripts/serviceWorker/sw.js.map Regenerated sourcemap (currently embeds absolute local paths).
core/scripts/serviceWorker/sw.js Regenerated Workbox service worker with updated precache revisions.
core/scripts/crispr_scripts.min.js Updates bundled UI behavior (inline feedback; Bootstrap 5 collapse attributes).
core/scripts/crispr_scripts.js Updates showFeedback() collapse attributes and removes modal-trigger logic from submitAnswers().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

AlexJSully and others added 3 commits February 19, 2026 14:58
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@AlexJSully AlexJSully merged commit 21a291e into master Feb 19, 2026
6 checks passed
@AlexJSully AlexJSully deleted the alexjsully-260219-fixed-unable-to-press-the-submit-button-again branch February 19, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants