Fixed unable to click the submit button again#86
Merged
AlexJSully merged 4 commits intomasterfrom Feb 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SciGrade submission/feedback UX to remove the Bootstrap modal-based feedback flow and render feedback inline via showFeedback(), with supporting doc updates and regenerated static assets.
Changes:
- Remove feedback modal markup from
core/systemrun.htmland stop triggering it fromsubmitAnswers(). - Update feedback UI collapse markup for Bootstrap 5 (
data-bs-*) inshowFeedback()and the minified bundle. - Update Playwright configuration and E2E test timing; refresh Workbox service worker artifacts and docs to match the new feedback flow.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/playwright/submission.spec.js | Adds an extra wait after form render (currently via fixed timeout). |
| playwright.config.js | Reduces Playwright worker count. |
| docs/index.md | Documents that feedback is rendered inline by showFeedback(). |
| docs/architecture/index.md | Updates architecture docs to reflect inline feedback UI (no modal). |
| core/systemrun.html | Removes the feedback modal/button markup from the runtime page. |
| core/scripts/serviceWorker/sw.js.map | Regenerated sourcemap (currently embeds absolute local paths). |
| core/scripts/serviceWorker/sw.js | Regenerated Workbox service worker with updated precache revisions. |
| core/scripts/crispr_scripts.min.js | Updates bundled UI behavior (inline feedback; Bootstrap 5 collapse attributes). |
| core/scripts/crispr_scripts.js | Updates showFeedback() collapse attributes and removes modal-trigger logic from submitAnswers(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.