[ALICE 3] Changed chip size and module number for TRK barrel + updated TRK documentation + included low services around beam pipe#15382
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the ALICE 3 TRK barrel geometry parameters and services modeling, aligning the simulated tracker layout (chip/module dimensions and counts) with the latest design, and expanding user-facing documentation for custom geometry configuration.
Changes:
- Update MLOT barrel configuration defaults (layer lengths and number of modules per stave) and refine config-file parsing readability.
- Add an optional “low services around the beam pipe” geometry for the Peacock services layout, controlled via a new
TRKBase.includeLowServicesconfigurable. - Update TRK documentation with detailed custom geometry configuration file format and examples; update chip length in specs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKServices.cxx | Adds optional low services volumes around the beam pipe for Peacock services layout. |
| Detectors/Upgrades/ALICE3/TRK/simulation/src/Detector.cxx | Updates default cylindrical lengths and segmented module counts; improves config-file parsing clarity. |
| Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/TRKServices.h | Declares the new beam-pipe low-services builder method. |
| Detectors/Upgrades/ALICE3/TRK/README.md | Adds detailed documentation for custom geometry configuration files and examples. |
| Detectors/Upgrades/ALICE3/TRK/base/include/TRKBase/TRKBaseParam.h | Introduces includeLowServices configurable and modernizes irisOpen type to bool. |
| Detectors/Upgrades/ALICE3/TRK/base/include/TRKBase/Specs.h | Updates chip length constant (module MLOT chip length). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
njacazio
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.