Skip to content

[ALICE 3] Changed chip size and module number for TRK barrel + updated TRK documentation + included low services around beam pipe#15382

Merged
njacazio merged 8 commits into
AliceO2Group:devfrom
scannito:trk
May 11, 2026
Merged

[ALICE 3] Changed chip size and module number for TRK barrel + updated TRK documentation + included low services around beam pipe#15382
njacazio merged 8 commits into
AliceO2Group:devfrom
scannito:trk

Conversation

@scannito
Copy link
Copy Markdown
Contributor

@scannito scannito commented May 8, 2026

No description provided.

@scannito scannito changed the title [ALICE 3] Changed pixel size and module number for TRK barrel + updated TRK documentation + included low services around beam pipe [ALICE 3] Changed chip size and module number for TRK barrel + updated TRK documentation + included low services around beam pipe May 8, 2026
@scannito scannito marked this pull request as ready for review May 11, 2026 14:10
@scannito scannito requested a review from mconcas as a code owner May 11, 2026 14:10
Copilot AI review requested due to automatic review settings May 11, 2026 14:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ALICE 3 TRK barrel geometry parameters and services modeling, aligning the simulated tracker layout (chip/module dimensions and counts) with the latest design, and expanding user-facing documentation for custom geometry configuration.

Changes:

  • Update MLOT barrel configuration defaults (layer lengths and number of modules per stave) and refine config-file parsing readability.
  • Add an optional “low services around the beam pipe” geometry for the Peacock services layout, controlled via a new TRKBase.includeLowServices configurable.
  • Update TRK documentation with detailed custom geometry configuration file format and examples; update chip length in specs.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKServices.cxx Adds optional low services volumes around the beam pipe for Peacock services layout.
Detectors/Upgrades/ALICE3/TRK/simulation/src/Detector.cxx Updates default cylindrical lengths and segmented module counts; improves config-file parsing clarity.
Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/TRKServices.h Declares the new beam-pipe low-services builder method.
Detectors/Upgrades/ALICE3/TRK/README.md Adds detailed documentation for custom geometry configuration files and examples.
Detectors/Upgrades/ALICE3/TRK/base/include/TRKBase/TRKBaseParam.h Introduces includeLowServices configurable and modernizes irisOpen type to bool.
Detectors/Upgrades/ALICE3/TRK/base/include/TRKBase/Specs.h Updates chip length constant (module MLOT chip length).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKServices.cxx
Comment thread Detectors/Upgrades/ALICE3/TRK/README.md
@njacazio njacazio merged commit 5608219 into AliceO2Group:dev May 11, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants