[OCTRL-1088]#816
Open
justonedev1 wants to merge 3 commits into
Open
Conversation
53d5a96 to
913d6af
Compare
knopers8
approved these changes
May 20, 2026
Collaborator
knopers8
left a comment
There was a problem hiding this comment.
Thanks, I took some time to get acquainted with the news and finally tried running it today - it works!
I have some minor questions, but it can be merged already. Please put a human-readable title to the PR though.
| "strings" | ||
|
|
||
| pb "github.com/AliceO2Group/ControlOperator/internal/controller/protos/generated" | ||
| pb "github.com/AliceO2Group/Control/operator/internal/controller/protos/generated" |
Collaborator
There was a problem hiding this comment.
hmm, isn't it control-operator?
Suggested change
| pb "github.com/AliceO2Group/Control/operator/internal/controller/protos/generated" | |
| pb "github.com/AliceO2Group/Control/control-operator/internal/controller/protos/generated" |
| task.Spec.Control = *template.Spec.Control.DeepCopy() | ||
|
|
||
| if foundIdx := slices.IndexFunc(taskReference.Env, func(envVar v1.EnvVar) bool { return envVar.Name == "OCC_CONTROL_PORT" }); foundIdx == -1 { | ||
| log.Error(fmt.Errorf("didn't find OCC_CONTROL_PORT in env"), "failed to fill in env vars from template") |
Collaborator
There was a problem hiding this comment.
Shouldn't we return if there is error?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apart from environment controller I also created separate binaries for environment manager and task manager, which is the cause of most of the yaml piping.