[DPG] tpcSkimsTableCreator: add RCT check, minor refactory#16196
Open
lubynets wants to merge 7 commits into
Open
[DPG] tpcSkimsTableCreator: add RCT check, minor refactory#16196lubynets wants to merge 7 commits into
lubynets wants to merge 7 commits into
Conversation
lubynets
requested review from
alcaliva,
alibuild,
catalinristea and
chiarazampolli
as code owners
|
O2 linter results: ❌ 1 errors, |
github-actions
Bot
changed the title
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major:
Enabled selection of tracks by Run Condition Table (for details see Common/CCDB/RCTSelectionFlags.h). The boolean column is added to each track, showing whether the latter belongs to "good" or "bad" event. Upon user's request tracks from "bad" events can be rejected.
Minor refactory:
Fixed typo; removed inline specifier from template functions; value-initialized uninitialized objects; removed redundant
&when r.h.s. is an rvalue; if-condition with complicated logic made more reading-friendly.Tagging @amaringarcia