Add --dry-run flag to CLI and dry_run option to API#61
Merged
Einswilli merged 3 commits intoAllDotPy:masterfrom Oct 18, 2025
Merged
Add --dry-run flag to CLI and dry_run option to API#61Einswilli merged 3 commits intoAllDotPy:masterfrom
Einswilli merged 3 commits intoAllDotPy:masterfrom
Conversation
Contributor
Author
|
@Einswilli kindly see my work and if its is okay kindly merge and give me feedback |
Einswilli
requested changes
Oct 17, 2025
Contributor
Einswilli
left a comment
There was a problem hiding this comment.
Looks great!
It'be great to display also file paths in verbose mode.
Thanks for your contributions!
Contributor
Author
Einswilli
requested changes
Oct 18, 2025
Contributor
Author
|
Hi @Einswilli I have removed the unnecessary blocks you mentioned above and added the matched_files. block in the download.py
|
Einswilli
approved these changes
Oct 18, 2025
Contributor
Einswilli
left a comment
There was a problem hiding this comment.
Thanks this looks cleaner 👍🏾
Great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Summary
This PR adds a "dry-run" preview mode to Forklet so users can see which files would be downloaded without creating directories or writing files.
--dry-run/-noption toforklet download.dry_run: boolsupport toDownloadRequest.dry_runis True and returns aDownloadResult-like summary.tests/core/test_orchestrator_dry_run.py.Why this change
What Changed
Files changed (high-level)
dry_run: bool = FalsetoDownloadRequest.--dry-run / -nclick option todownloadcommand.python -m forklet.dry_runintoDownloadRequest._current_resultearlier for consistent status endpoints.dry_run=Truereturns the expected summary and does not create files.Behavior
--dry-runis passed, Forklet:downloaded_files == []and does NOT create directories or write files.--verboseincreases logging and shows debug lines.How to test (quick)
masteras ref for TheAlgorithms/Python):Notes for reviewers
DownloadResult-like object (status set to COMPLETED). If reviewers prefer an explicitwas_dry_runflag on the result, I can add that in a follow-up.Checklist for merge
closes #60