Skip to content

Format accessibilityDescription #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hannesa2 merged 1 commit into from
Feb 10, 2026
Merged

Format accessibilityDescription #718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions chartLib/src/main/kotlin/info/appdev/charting/charts/LineChart.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import android.util.AttributeSet
import info.appdev.charting.data.LineData
import info.appdev.charting.interfaces.dataprovider.LineDataProvider
import info.appdev.charting.renderer.LineChartRenderer
import java.util.Locale

open class LineChart : BarLineChartBase<LineData>, LineDataProvider {

Expand Down Expand Up @@ -39,9 +38,6 @@ open class LineChart : BarLineChartBase<LineData>, LineDataProvider {

override val accessibilityDescription: String
get() {
val lineData = lineData
val numberOfPoints = lineData.entryCount

// Min and max values...
val yAxisValueFormatter = axisLeft.valueFormatter
val minVal = yAxisValueFormatter?.getFormattedValue(lineData.yMin, null)
Expand All @@ -51,13 +47,10 @@ open class LineChart : BarLineChartBase<LineData>, LineDataProvider {
val xAxisValueFormatter = xAxis.valueFormatter
val minRange = xAxisValueFormatter?.getFormattedValue(lineData.xMin, null)
val maxRange = xAxisValueFormatter?.getFormattedValue(lineData.xMax, null)
val entries = if (numberOfPoints == 1) "entry" else "entries"
return String.format(
Locale.getDefault(), "The line chart has %d %s. " +
"The minimum value is %s and maximum value is %s." +
"Data ranges from %s to %s.",
numberOfPoints, entries, minVal, maxVal, minRange, maxRange
)
val pluralOrSingular = if (lineData.entryCount == 1) "entry" else "entries"
return "The line chart has ${lineData.entryCount} $pluralOrSingular. " +
"The minimum value is $minVal and maximum value is $maxVal." +
"Data ranges from $minRange to $maxRange."
}

}
Loading