feat(themes): add "radical" as an alias for "redical" - #246
Conversation
The "redical" theme appears to have been introduced as a misspelling of "radical" (its color palette matches the radical theme of anuraghazra/github-readme-stats exactly). A previous rename attempt (Ashutosh00710#236) was closed to avoid breaking users who already configured theme=redical. This change keeps "redical" working as before and adds "radical" as a fall-through alias with the same colors, so newcomers can discover the canonical name without disrupting existing users.
|
@mado-m is attempting to deploy a commit to the ashutosh00710's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Also — I'm using this on my profile README (mado-m/mado-m) and it has been great. Thanks for the work you've put into this project! |
mado-m
changed the title
|
@Ashutosh00710 Gentle ping on this — would you have a chance to take a look when you get a moment? Happy to adjust anything if needed. Thanks! |
There was a problem hiding this comment.
@mado-m Thanks for adding backward compatibility support for redical.
I requested changes mainly around exposing both redical and radical as separate public themes. Since both map to the same theme, this creates a UX issue where users may assume they are different.
I think redical should remain only as an internal compatibility alias, while radical stays the single public theme name.
| @@ -118,6 +118,7 @@ <h1 class="heading">GitHub Readme Activity Graph</h1> | |||
| <option value="rogue">Rogue</option> | |||
| <option value="xcode">Xcode</option> | |||
| <option value="redical">Redical</option> | |||
There was a problem hiding this comment.
Let's expose only the canonical radical theme publicly and keep redical only as a backward compatibility alias internally. Please remove this line.
There was a problem hiding this comment.
Addressed in 8c4357f: radical is now the only public theme name, and redical remains accepted internally in selectColors for backward compatibility.
| @@ -29,6 +29,7 @@ const themes = { | |||
| rogue: { bgColor: '#172030', line: '#b18bb1', point: '#c6797e', color: '#a3b09a' }, | |||
| xcode: { bgColor: '#202124', line: '#c4e3ff', point: '#ff8070', color: '#fcfcfa' }, | |||
| redical: { bgColor: '#141321', line: '#fe428e', point: '#f8d847', color: '#a9fef7' }, | |||
There was a problem hiding this comment.
Same concern as @index.html
There was a problem hiding this comment.
Addressed in 8c4357f: radical is now the only public theme name, and redical remains accepted internally in selectColors for backward compatibility.
| | Name | Preview | | ||
| | :--------------------: | :----------------------------------------------------------------: | | ||
| | **radical** | <img src="./asset/redical.svg" height=250 alt="graph"/> | | ||
| | **redical** | <img src="./asset/redical.svg" height=250 alt="graph"/> | |
There was a problem hiding this comment.
Same concern as @index.html
There was a problem hiding this comment.
Addressed in 8c4357f: radical is now the only public theme name, and redical remains accepted internally in selectColors for backward compatibility.
0ae4a77 to
8c4357f
Compare
2 participants
Summary
This PR adds
radicalas an alias for the existingredicaltheme. Both names map to the same colors, so no existing user is broken.Background
The
redicaltheme appears to have been introduced as a misspelling ofradical(its color palette matches theradicaltheme ofanuraghazra/github-readme-statsexactly:#141321/#fe428e/#a9fef7/#f8d847).A previous attempt to rename it (#236) was closed because renaming would break users who already configured
theme=redical. This PR takes a different approach: keepredicalworking forever, while letting new users discover and use the canonical nameradical.Changes
src/styles/themes.ts: add acase 'radical':fall-through next toredical, with a comment explaining the history__test__/themes.test.ts: add an assertion thatradicalreturns the same colors asredicalTHEMES.md: listradicalin the theme table (sharing theredical.svgpreview since the colors are identical)index.html/script.js: exposeradicalin the web preview UITest plan
npx jest __test__/themes.test.ts— passes (1 test, 23 assertions)theme=redicalusersthemes.tsreflects the intended positionThanks for maintaining this project — I use it on my own profile README (github.com/mado-m/mado-m) and it has been great. Hopefully this small alias makes it a bit easier for newcomers without disrupting anyone.