refactor(dependencies): add missing packages and fix import paths - #248
Open
maurodesouza wants to merge 1 commit into
Open
refactor(dependencies): add missing packages and fix import paths#248maurodesouza wants to merge 1 commit into
maurodesouza wants to merge 1 commit into
Conversation
- Add @panosoft/ramda-utils, co, is_js, and ramda dependencies - Update node-chartist imports to use standard module paths instead of relative paths
|
@maurodesouza is attempting to deploy a commit to the ashutosh00710's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses dependency management issues and improves import path stability for the
node-chartistlibrary, specifically to resolve installation failures when using this project as a dependency in a GitHub Action.Problem
When attempting to use this project as a library within a GitHub Action (via
github:Ashutosh00710/github-readme-activity-graph), the action failed during thepnpm installstep because several packages were being imported in the code but were not declared inpackage.json. This caused the dependency resolution to fail, preventing the action from running.Additionally,
node-chartistimports were using relative paths to internal library files (node-chartist/lib/...), which is fragile and could break if the library's internal structure changes in future versions.Changes
1. Added missing dependencies to package.json
Ru.defaults)co.wrap)is.function,is.not.json)R.curryN)These packages were already being imported and used in the code but were missing from the dependency declarations. This caused installation failures when the project was consumed as a dependency via pnpm, as the package manager could not resolve these implicit dependencies.
2. Updated node-chartist imports
Changed from relative path imports:
To standard module path imports (using the package's main entry point):
This change makes the imports more resilient to internal library restructuring and follows better Node.js module resolution practices.
Impact
All Submissions
New Feature Submissions
Changes to Core Features