fix(dashboard): restore plugin card changelog and author#6668
fix(dashboard): restore plugin card changelog and author#6668ccsang wants to merge 2 commits intoAstrBotDevs:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a regression in the dashboard by reintroducing critical information to installed plugin cards. It focuses on enhancing the user experience by making the changelog accessible and displaying author details, including clickable social links, for installed extensions. The modifications are carefully confined to installed plugin cards to prevent unintended side effects on the market mode interface. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="dashboard/src/components/shared/ExtensionCard.vue" line_range="337-345" />
<code_context>
+ size="x-small"
+ class="extension-author-row__icon"
+ ></v-icon>
+ <a
+ v-if="extension.social_link"
+ :href="extension.social_link"
+ target="_blank"
+ rel="noopener noreferrer"
+ class="extension-author-row__link"
+ @click.stop
+ >
+ {{ extension.author }}
+ </a>
+ <span v-else class="extension-author-row__text">
</code_context>
<issue_to_address>
**🚨 issue (security):** Consider sanitizing or constraining `extension.social_link` before binding it to `href`.
Since this value comes from extensions, it could include `javascript:` or other unsafe schemes. Ensure only expected protocols (e.g., `https`, `http`) are allowed, or require callers to pass a pre-validated URL so this anchor can’t render dangerous schemes.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Code Review
This pull request successfully restores the author and changelog information on plugin cards as intended. The implementation is clean and correctly scoped to installed plugins, leaving the market view unchanged. The new UI elements are well-styled and functional. I have one minor suggestion regarding the use of typography to improve consistency with the existing design system. Overall, great work!
Summary
view-changelogflow back into the installed-card action menusocial_linkclickable when availableTesting
cd dashboard && pnpm install --frozen-lockfilecd dashboard && pnpm run typecheckcd dashboard && pnpm run lint -- src/components/shared/ExtensionCard.vue(fails because of existing repository-wide ESLint/parser configuration issues, not this patch specifically)Fixes #6639
Summary by Sourcery
Restore installed plugin card metadata and actions in the dashboard UI.
New Features:
Enhancements: