Fix Hexagon build errors in iir_tdf2 and audio_filter#93
Merged
Conversation
quic-annemari
force-pushed
the
hexagon_fix
branch
from
4bd58d4 to
258fb48
Compare
Two build failures observed when compiling for Hexagon targets:
1. iir_tdf2.c includes audio_iir_tdf2_asm.h under __hexagon__
guard but the header was absent from the repository:
iir_tdf2.c:14:10:
fatal error: 'audio_iir_tdf2_asm.h' file not found
2. biquad_process_io() in audio_filter.cpp accesses yL16 and
xL16 members absent from the Hexagon _biquadFilter variant:
audio_filter.cpp:465:27:
error: no member named 'yL16' in '_biquadFilter'
audio_filter.cpp:466:27:
error: no member named 'xL16' in '_biquadFilter'
Add audio_iir_tdf2_asm.h to modules/cmn/common/utils/inc/ and
fix the missing Hexagon guard in biquad_process_io().
Signed-off-by: Annemarie Porter <annemari@qti.qualcomm.com>
quic-annemari
force-pushed
the
hexagon_fix
branch
from
258fb48 to
4c099d3
Compare
quic-aditrath
changed the title
qti-sbojja
approved these changes
Jun 4, 2026
quic-plai
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Hexagon build errors in iir_tdf2 and audio_filter
Two build failures observed when compiling for Hexagon targets:
iir_tdf2.c includes audio_iir_tdf2_asm.h under hexagon
guard but the header was absent from the repository:
iir_tdf2.c:14:10:
fatal error: 'audio_iir_tdf2_asm.h' file not found
biquad_process_io() in audio_filter.cpp accesses yL16 and
xL16 members absent from the Hexagon _biquadFilter variant:
audio_filter.cpp:465:27:
error: no member named 'yL16' in '_biquadFilter'
audio_filter.cpp:466:27:
error: no member named 'xL16' in '_biquadFilter'
Add audio_iir_tdf2_asm.h to modules/cmn/common/utils/inc/ and
fix the missing Hexagon guard in biquad_process_io().