fix(dev-env): address deprecations in myloader#2772
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
sjinks
commented
Mar 12, 2026
Comment on lines
13952
to
13954
Member
Author
There was a problem hiding this comment.
A bit unrelated; fixes a high-severity vulnerability in tar
Ref: CVE-2026-31802
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a deprecation warning in myloader by replacing the deprecated --innodb-optimize-keys flag with the new --optimize-keys flag, ensuring compatibility with mydumper 0.21.3-1. It also includes a minor tar dependency bump.
Changes:
- Replace deprecated
--innodb-optimize-keyswith--optimize-keysin the SQL import command - Bump
tardependency from 7.5.10 to 7.5.11
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/commands/dev-env-import-sql.ts | Replace deprecated myloader flag --innodb-optimize-keys with --optimize-keys |
| npm-shrinkwrap.json | Bump tar from 7.5.10 to 7.5.11 |
Files not reviewed (1)
- npm-shrinkwrap.json: Language not supported
You can also share your feedback on Copilot code review. Take the survey.
luismulinari
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the following error that happens during
vip dev-env import sql:Changelog Description
Fixed
mydumper0.21.3-1Pull request checklist
New release checklist
Steps to Test
See 222938-z