fix: keep progressBar alive during MapDataStoreable iterations#103
Open
terbin wants to merge 1 commit into
Open
fix: keep progressBar alive during MapDataStoreable iterations#103terbin wants to merge 1 commit into
terbin wants to merge 1 commit into
Conversation
MapDataStoreable.store() writes each map_*.dat synchronously in its forEach loop. On captures with thousands of maparts the loop blocks the IO coroutine for many seconds without touching StorageFlow.lastStoredTimestamp, so BarManager.updateCapture's decay branch (default 3000ms) clears lastStored and the progressBar widget disappears mid-save. Mirror the timestamp-refresh pattern from MetadataStoreable and CompressLevelStoreable: refresh lastStoredTimestamp per iteration, and seed lastStored at store() entry so the progressBar text reads "Saved maps in dimension X" through the slow phase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MapDataStoreable.store() writes each map_*.dat synchronously in its forEach loop. On captures with thousands of maparts the loop blocks the IO coroutine for many seconds without touching StorageFlow.lastStoredTimestamp, so BarManager.updateCapture's decay branch (default 3000ms) clears lastStored and the progressBar widget disappears mid-save.
Mirror the timestamp-refresh pattern from MetadataStoreable and CompressLevelStoreable: refresh lastStoredTimestamp per iteration, and seed lastStored at store() entry so the progressBar text reads "Saved maps in dimension X" through the slow phase.
Verification
progressBar stays visible during MapDataStoreable on a 2b2t mapart-exhibition reproducer (10k+ maparts), confirmed across the full save phase instead of vanishing after ~3s of forEach blocking.