add moderator tools#813
Conversation
Sereri
left a comment
Sereri
left a comment
There was a problem hiding this comment.
Looks pretty good, some minor questions. Astral helped me with testing.
Please consider adding your SA username to about_contributors_array so I have someone to blame, obviously you do not have to.
| awfulActions.add(prefs.blockedAvatarUrls.contains(posterAvatarUrl) ? | ||
| SHOW_AVATAR : HIDE_AVATAR); | ||
| } | ||
| if (!ownPost && (editable || hasModControls)) { |
There was a problem hiding this comment.
I mean if we're going for parity, mod tools should be available for your own posts as well. There have been some comedy self-probations in the past that I can remember.
There was a problem hiding this comment.
Can we rename this to something else? I'm not saying only tasks can have "Request" in the filename but maybe something like [Queue]ModActionFragment would be more descriptive?
There was a problem hiding this comment.
The text boxes look a bit weird on my phone, is this normal?
Comparing this to the login screen for example
2 participants
have wanted to do this for a while so i can stop switching to my browser or computer to do sixers (read: probes/bans for the numbers guy)
should be straightforward, but a few points
I moved "edit post" for other users' posts into the new moderation submenu because otherwise it's a huge trap (like it is on desktop lol) to accidentally edit a different user's post instead of your own or quoting it
I never know when to do Kotlin versus Java files - I assume the idea is that new stuff is Kotlin and old stuff might some day be ported to Kotlin instead? I preferred Kotlin for these new files but could easily switch them to Java...
I made sure to make the strings translatable even when the neighboring ones aren't... not sure if you'd prefer me to match the existing code or do the better strings.xml stuff - again could easily switch it the other way
I've been testing this for a few weeks now, seems to work well. I didn't hook up the mod queue or anything (the page that shows up after you queue a probe/ban) because that's unnecessary, I just bounce you back to the page you were on before and show a toast about it being queued.
there's no title change/blank, etc.. just probe/ban (and the existing edit). i never do those other things anyways and don't think they're common enough for anyone else to care
I pull most of the stuff from the actual probe/ban request page, but some strings were copied from that verbatim.
since this isn't as easily testable by most users, I erred on the side of more comments than normal (and tried to make them more technically specific). also that's why things are named as closely as possible to the PHP stuff, so it's more of a one-to-one translation from web to app
screenshots in action:
new button at bottom of post context menu (if you can do mod stuff or edit):
brings open submenu
then probe page with duration choice:
or ban page with ban vs permaban:
idk if the "probation: 2" is useful but it's on the existing browser page so I left it