Merged
Conversation
Capturing them silently since this may commonly happen with responsive sources
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an ADA (accessibility) pause control issue with responsive video sources, where videos would prematurely trigger a load before playback completed. The changes modernize error handling in the play() function and update callback invocation syntax to use optional chaining.
Key changes:
- Refactored error handling in the
play()function from try-catch to inline promise rejection handling - Updated callback invocations to use optional chaining syntax (
?.())
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an issue with responsive video sources. They would immediately cause a load before the play finished.