fix(cli): surface invalid env credential upstreams - #1640
Merged
Conversation
Contributor
Codecov Results 📊✅ Patch coverage is 90.00%. Project has 8179 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 80.33% 80.33% —%
==========================================
Files 218 218 —
Lines 41573 41590 +17
Branches 32929 32935 +6
==========================================
+ Hits 33396 33411 +15
- Misses 8177 8179 +2
- Partials 3643 3645 +2Generated by Codecov Action |
BYK
force-pushed
the
fix/seer-env-credential-upstream
branch
from
August 17, 2026 11:05
60303ed to
2f3d60b
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reports an invalid configured upstream URL without silently discarding a valid shell credential or crashing
lore import. Follow-up to Seer reviews on #1632 and this PR:Changes
Verification
pnpm run typecheckpnpm run format:check