feat: adding a way to use different values for max capacity query#506
Open
maugustosemperfi wants to merge 1 commit intoBaseflow:developfrom
Open
Conversation
2 tasks
Syed-Bipul-Rahman
approved these changes
Jan 23, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Feature - Adds a new configurable
maxCapacityAgeFilterDurationparameter to customize the age threshold for cache object cleanup.When cleaning up cache objects over capacity, the
getObjectsOverCapacitymethod uses a hardcodedDuration(days: 1)filter. This means only objects that haven't been touched in the last 24 hours are considered for removal, with no way to customize this behavior.🆕 What is the new behavior (if this is a feature change)?
maxCapacityAgeFilterDurationoptional parameter toConfiggetObjectsOverCapacitymethod now accepts amaxAgeparameterCacheStoreuses the configured duration (falling back to 1 day if not set)CacheObjectProvider,JsonCacheInfoRepository,NonStoringObjectProvider) updated to support the new parameterThis allows users to configure how recently an object must have been accessed before it becomes a candidate for removal during over-capacity cleanup.
💥 Does this PR introduce a breaking change?
No - The parameter is optional with a default value matching the previous hardcoded behavior (
Duration(days: 1)).🐛 Recommendations for testing
maxCapacityAgeFilterDuration(e.g.,Duration(seconds: 10))📝 Links to relevant issues/docs
N/A
🤔 Checklist before submitting