Fix cache invalidation and button to flush the cache manually#34
Merged
Conversation
asadowski10
previously approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR update fixes the cache invalidation issue when an attachment is added, edited or deleted.
It also adds a button in the admin bar to manually flush the cache.
Fix #26
Note
Low Risk
Low risk: changes are limited to transient cache invalidation and a nonce-protected admin-only cache flush action, with minimal impact outside admin workflows.
Overview
Fixes SVG icon cache staleness by invalidating the transient when SVG attachments are added/edited/deleted (replacing the previous attachment save hook).
Adds an admin-bar “Flush ACF SVG Icon cache” action that deletes the cached transient via a nonce-verified,
manage_options-gated handler, and centralizes the cache key asACF_SVG_ICON_CACHE_KEY(updating translations accordingly).Reviewed by Cursor Bugbot for commit 8c4c24b. Bugbot is set up for automated code reviews on this repo. Configure here.