Skip to content

Refactor filename sanitization logic and expand unit tests #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
herewithme merged 1 commit into from
Apr 7, 2026
Merged

Refactor filename sanitization logic and expand unit tests #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions bea-sanitize-filename.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,30 +75,33 @@ function bea_sanitize_file_name( $file_name = '' ) {
return $file_name;
}

// get extension
preg_match( '/\.[^\.]+$/i', $file_name, $ext );

// No extension, go out ?
if ( ! isset( $ext[0] ) ) {
// Separate filename and extension (last segment after the final dot).
$extension = pathinfo( $file_name, PATHINFO_EXTENSION );
if ( '' === $extension ) {
return $file_name;
}

// Get only first part
$ext = $ext[0];
$suffix = '.' . $extension;
$suffix_length = strlen( $suffix );

// work only on the filename without extension
$file_name = str_replace( $ext, '', $file_name );
// Strip the suffix only at the end; str_replace( $suffix, '', $file_name ) would remove every occurrence.
if ( ! str_ends_with( $file_name, $suffix ) ) {
return $file_name;
}

$file_name = substr( $file_name, 0, -$suffix_length );

// only lowercase
$file_name = mb_strtolower( $file_name );

// remove accents
$file_name = remove_accents( $file_name );

// replace _ by -
$file_name = str_replace( '_', '-', $file_name );

// Return sanitized file name
return $file_name . $ext;
return $file_name . $suffix;
}

add_filter( 'sanitize_file_name', 'bea_sanitize_file_name', 10, 1 );
Loading
Loading