889116 - Make log optional + zip log file when size exceed retention_size#20
Open
pngouahbeapi wants to merge 1 commit into
Open
889116 - Make log optional + zip log file when size exceed retention_size#20pngouahbeapi wants to merge 1 commit into
pngouahbeapi wants to merge 1 commit into
Conversation
Rahe
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches cron-time filesystem logging behavior (enable/disable + rotation/compression), which could impact debugging visibility and file/permission expectations in production.
Overview
Adds
bea_sender_is_file_logging_enabled()(configurable viaBEA_SENDER_FILE_LOGGINGorbea_sender_file_logging_enabled) and wires it into the sender and bounce cron loggers so file logging can be turned off.Updates
Bea_Logto accept a write-enabled flag (making logging a no-op when disabled) and, on rotation, optionally compresses rotated log files into.ziparchives whenZipArchiveis available; bumps plugin version to1.4.5and documents the change in the changelog.Reviewed by Cursor Bugbot for commit 12d897b. Bugbot is set up for automated code reviews on this repo. Configure here.