chore(config): migrate DI configuration from XML to PHP (services.php) [Fixes #66] #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) to fix symfony 7.4 deprecation
Member
|
Please apply the changes suggested by StyleCI |
garak
requested changes
Oct 10, 2025
Member
garak
left a comment
garak
left a comment
There was a problem hiding this comment.
An update in .php-cs-fixer.php is needed to take into account the config path
| $services = $configurator->services(); | ||
|
|
||
| // sensible defaults | ||
| $services->defaults() |
Member
There was a problem hiding this comment.
This part should not be here, please remove
| $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../../config')); | ||
| $loader->load('services.xml'); | ||
| $loader = new PhpFileLoader($container, new FileLocator(__DIR__.'/../../config')); | ||
| $loader->load('services.php'); |
Member
|
Gentle bump. |
Member
|
Please take action; otherwise, I'll be forced to close this due to missing feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the bundle DependencyInjection configuration away from XML (deprecated in Symfony 7.4) to a modern PHP
services.phpfile.Changes
XmlFileLoaderwithPhpFileLoaderinBeelabRecaptcha2Extension.config/services.phpwith all service definitions:beelab_recaptcha2.google_recaptchaservice with constructor arguments.recaptcha2validator service (tagged asvalidator.constraint_validator).RecaptchaTypeform type service (tagged asform.type).RequestMethodPass) by preserving service IDs and argument positions.Why
XmlFileLoader).Testing
Notes
RequestMethodPass,TwigFormPass) continue to function as expected.