This repository was archived by the owner on Apr 20, 2021. It is now read-only.
Open
Conversation
ec80534 to
90ac460
Compare
Contributor
Author
|
ready to merge |
|
👍 |
Member
|
Good work, I have just one point: the key and modifier arguments need more abstration. Something like that: Then I press key "a"
Then I press key "<enter>"
Then I press key "Ctrl+A" |
3dba717 to
75bbff1
Compare
Contributor
Author
|
|
Member
No, this is what I think, but simpler than a regex: function convertKey($char)
{
static $specialKeys = [
'<enter>' => 13,
];
list($modifier, $key) = explode('+', $char, 2);
if (isset($specialKeys[$key])) {
$key = $specialKeys[$key];
}
return [$modifier, $key];
}Not tested and I don’t know if multiple modifiers are supported by mink. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It make it possible to press a specific keyboard key.
example: