This repository was archived by the owner on Apr 20, 2021. It is now read-only.
Fix parameter name on http files#268
Open
kevin-verschaeve wants to merge 1 commit intoBehatch:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Today I was facing an issue, that I fixed with the code in the PR.
The issue is, that I was not having the same results with an
UploadedFileobject in test and in dev.For now, if you add a file in your request like this:
In tests, the property
$uploadedFile->getClientOriginalName()returnsfile, and$uploadedFile->getClientOriginalExtension()returnsnull.But in dev, same calls returns
my_real_filename.txtandtxt.So my feature works in dev, but does not pass tests ...
This come from the
originalNameof theUploadedFileclass.Let me know if this sounds good or bad to you.
Thanks