Add light theme with light/dark/system toggle#6
Draft
BenItBuhner wants to merge 1 commit into
Draft
Conversation
Introduce CSS variable-based theming so the control surface supports both light and dark palettes without duplicating Tailwind classes. Add a theme provider that persists the user preference to localStorage, applies the resolved theme before first paint to avoid flash, and listens for system preference changes when set to system mode. Place a three-way theme toggle in the app shell sidebar and on the login page. Co-authored-by: Bennett Buhner <BenItBuhner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves OSP-104 by adding a full light theme and an easy three-way toggle to switch between Light, Dark, and System theming across the Model Proxy control surface.
Changes
ink,bone,phosphor, andalertpalette tokens to CSS variables inglobals.css, with light values on:rootand dark values on.darkdarkMode: "class"and mapped Tailwind color/shadow tokens to the new CSS variables so existing component classes work in both themes without a large refactorThemeProviderwithlocalStoragepersistence (mp_theme), system preference detection, and live updates when OS theme changes#CDFF00row highlights withvar(--phosphor-500)Testing
npm run typecheck— passnpm run build— pass (static export)Screenshots
Toggle appears in the sidebar (authenticated pages) and top-right on the login page. Selecting Light/Dark/System updates the full page background, panels, text, and accents immediately.
Linear Issue: OSP-104