allow leaderboard score to fit on one line - #524
Open
fdoyle wants to merge 2 commits into
Open
Conversation
Collaborator
|
Thanks this. Unfortunately all that extra space makes the design look a bit awkward. Could we try setting the padding/margins/whatever causing space on the left to 0? |
Author
|
Improved this a bit. Now 3 ems, but 4 numerical digits seems to fit in that easily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed layout name to row_profile for consistency with other list item layouts
set ems to 4 on score textview to guarantee that 4 digits can always safely fit in that space regardless of font (if someone hits a score of 10k, I suppose we'd have to update it again)