frontend: change amountSat to amount string#4220
Draft
thisconnect wants to merge 1 commit into
Draft
Conversation
thisconnect
force-pushed
the
lightning-amount-as-string
branch
from
cedc4eb to
23ecc3f
Compare
The frontend should handle amounts as string so we dont run into JavaScript 64-bit floating point number limitations.
thisconnect
force-pushed
the
lightning-amount-as-string
branch
from
23ecc3f to
52a5dc7
Compare
Collaborator
Author
|
rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frontend should handle amounts as string so we dont run into JavaScript 64-bit floating point number limitations.
Before asking for reviews, here is a check list of the most common things you might need to consider: