feat(sdk-coin-polyx): replace placeholder v8 testnet metadata with live RPC#9145
Draft
nvrakesh06 wants to merge 2 commits into
Draft
feat(sdk-coin-polyx): replace placeholder v8 testnet metadata with live RPC#9145nvrakesh06 wants to merge 2 commits into
nvrakesh06 wants to merge 2 commits into
Conversation
…ve chain RPC Regenerate testnetV8.ts from testnet-rpc.polymesh.live (specVersion 8000000) so V8 builders encode real v8 call indices (e.g. transferWithMemo @ 0x0528). Add a regeneration script and tests asserting metadata differs from v7 and encodes HSM method ID 1320. Mainnet v8 material stays placeholder until mainnet fork. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
…aterial V8 chain material is committed in src/resources/testnetV8.ts the same way as v7 testnet.ts — no runtime or build-time RPC fetch. Remove the regenerate script that called testnet-rpc.polymesh.live. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testnetV8.tsfromtestnet-rpc.polymesh.live(specVersion: 8000000,txVersion: 8) — metadata bytes now differ from v7 (no longer a placeholder copy).scripts/regenerateTestnetV8Material.tsfor future refreshes.V8TransferBuildertests: metadata ≠ v7,transferWithMemoencodes call index0x0528(HSM method ID 1320).mainnetV8.tsremains placeholder until mainnet v8 fork (mainnet still on spec 7004001).Why
CECHO-1471 shipped V8 builders with v7-mirroring metadata. Real v8 testnet signing requires actual chain metadata so builders emit correct call indices.
Depends on / pairs with
feat/CECHO-1473-real-v8-hsm-method-ids-and-parsers(registers method IDs 1320 + 1816)feat/CECHO-1471-wp-preserve-v8-builder-material(stops overwriting v8 builder material with IMS v7 metadata)Follow-ups (not in this PR)
V8TokenTransferBuilderstill uses v7portfoliosarg shape — needsholderSet/AssetHolderbuilder update for real v8 settlement txsV8RegisterDidBuilderforidentity.registerDid@ 1816 (currentlyV8RegisterDidWithCDDBuilder)mainnetV8.tsafter mainnet fork (~July 22, 2026)Test plan
yarn unit-test-minimal -p sdk-coin-polyx --grep V8TransferBuildertestnetV8Material.metadata !== testnetMaterial.metadataMade with Cursor