refactor: update titles and descriptions in QR keycard data gen#9146
Open
danielpeng1 wants to merge 1 commit into
Open
refactor: update titles and descriptions in QR keycard data gen#9146danielpeng1 wants to merge 1 commit into
danielpeng1 wants to merge 1 commit into
Conversation
Contributor
vmccarty
approved these changes
Jun 30, 2026
vmccarty
left a comment
vmccarty
left a comment
Contributor
There was a problem hiding this comment.
Wonderful update. Consistent, clean, and minimal. I'm all for it 🙆♀️
alextse-bg
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating verbiage on keycard PDF (old
sdk-corepath and newkey-cardmodule) as per ticketand
See example of the updated copy here (data is fake):
Ticket: WCN-520
Minor notes: fixed pre-existing double space in old
sdk-corekeycard.