test: add integration test coverage for SDK bump regressions (WAL-1484)#205
Merged
Conversation
Five gaps identified during manual SDK bump regression testing that would go undetected by CI without these changes: 1. eddsa.test.ts — fix wrong coin in test fixture (tsol → tnear) so the test actually exercises the EdDSA key finalization path it claims to cover 2. recoveryWallet.test.ts — add ETH happy path test; ETH recovery calls recover() on the coin object directly rather than building a PSBT and hits a different AWM endpoint shape, so a regression there was invisible 3. mpcFinalize.test.ts — add backup source finalization test; the handler dispatches on source='user' vs source='backup' to set party indexes and signing material field names — only the user path was tested before 4. recoveryConsolidationsWallet.test.ts — replace Prototype-level sinon stubs with nock HTTP interceptors so the real AdvancedWalletManagerClient code path (URL routing, body serialization, codec decoding) is exercised; adds body capture assertions so URL/shape regressions are caught 5. consolidate.test.ts — add walletPubs argument verification on the signing function call; a regression that dropped walletPubs would silently pass because the stub accepts any args Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pranavjain97
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Today, we run verify regression manually for each release, this isn't possible. This PR aims to audit any missing tests for major flows like generate, signing, etc. and add any automated tests that can catch potential regressions. No functional change, just enhancement of tests.
What
Five gaps identified during manual SDK bump regression testing that would go undetected by CI without these changes:
eddsa.test.ts — fix wrong coin in test fixture (tsol → tnear) so the test actually exercises the EdDSA key finalization path it claims to cover
recoveryWallet.test.ts — add ETH happy path test; ETH recovery calls recover() on the coin object directly rather than building a PSBT and hits a different AWM endpoint shape, so a regression there was invisible
mpcFinalize.test.ts — add backup source finalization test; the handler dispatches on source='user' vs source='backup' to set party indexes and signing material field names — only the user path was tested before
recoveryConsolidationsWallet.test.ts — replace Prototype-level sinon stubs with nock HTTP interceptors so the real AdvancedWalletManagerClient code path (URL routing, body serialization, codec decoding) is exercised; adds body capture assertions so URL/shape regressions are caught
consolidate.test.ts — add walletPubs argument verification on the signing function call; a regression that dropped walletPubs would silently pass because the stub accepts any args
Ticket: WAL-1484