fix: emit null instead of empty string in JSON output - #16
Merged
Conversation
julianschiavo
force-pushed
the
fix/json-nil-coercion
branch
from
March 13, 2026 05:49
d56296e to
bc06581
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
julianschiavo
force-pushed
the
fix/json-nil-coercion
branch
from
March 13, 2026 05:57
bc06581 to
b13e8af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocumentationSearchDocument.contentsand.titlefromString(defaultingnilto"") toString?so JSON output emitsnullfor missing valuesencode(to:)to ensure nil optionals are always serialized asnullkeys rather than omittedSearchJSONOutputTestsverifying null emission and non-nil preservationNote
Low Risk
Low risk: only changes CLI JSON encoding of
title/contentsfrom empty strings to explicitnull, plus adds focused regression tests.Overview
Updates the
search --jsonoutput to preserve missing fields as JSONnullby makingDocumentationSearchDocument.title/contentsoptional and encoding them explicitly (instead of coercingnilto empty strings or dropping keys).Adds
SearchJSONOutputTeststo verifynilvalues serialize asnulland non-nilvalues remain unchanged.Written by Cursor Bugbot for commit b13e8af. This will update automatically on new commits. Configure here.