fix: append article subtopic content - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes vector-search result shaping by fetching and merging descendant topic content and filtering out subtopic hits, which can affect search/entry output and performance. Also adds a new Objective-C selector bridge (
stringIdentifiersApplyingFilters) that could fail at runtime if the private API differs across OS versions.Overview
Search and exact entry lookups now expand article content with descendant topic content (identifiers using the
parent#childconvention), so parent articles include subtopic text whenomitContentis false.This adds a new
VSKClientObject.stringIdentifiers(applying:)bridge to fetch identifiers by attribute filters, uses it to discover topic identifiers, fetches descendant assets in bulk, appends theircontentonto the parent hit, and deduplicates search results so subtopics aren’t returned separately when the parent article is present.Adds live integration tests covering content expansion and subtopic deduplication, plus new live-environment fixtures for an article with subtopics.
Written by Cursor Bugbot for commit 207c363. This will update automatically on new commits. Configure here.