Rename ExceptionCatcher to XCDocsExceptionCatcher across package - #26
Open
krzyzanowskim wants to merge 1 commit into
Open
Rename ExceptionCatcher to XCDocsExceptionCatcher across package#26krzyzanowskim wants to merge 1 commit into
krzyzanowskim wants to merge 1 commit into
Conversation
- Update Package.swift: rename target, change path, adjust dependencies for XCDocsBridge and tests. - Move Sources/ExceptionCatcher -> Sources/XCDocsExceptionCatcher. - Update imports in MADServiceObject.swift and ExceptionCaptureTests.swift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target name
ExceptionCatcheris unfortunate and conflicts with https://github.com/sindresorhus/ExceptionCatcher package. The unfortunate part is that SwiftPM requires all targets unique in the graph 🤷I propose rename ExceptionCatcher → XCDocsExceptionCatcher
Note
Low Risk
Low risk rename-only change, but it can break builds for any downstream consumers or internal references that still import
ExceptionCatcheror expect the old target path/name.Overview
Renames the SwiftPM target/module from
ExceptionCatchertoXCDocsExceptionCatcher, including moving its target path toSources/XCDocsExceptionCatcherand updating target dependencies inPackage.swift.Updates code and tests to import
XCDocsExceptionCatcher(e.g.,MADServiceObjectandExceptionCaptureTests) so the Objective-C exception catching helper continues to compile under the new module name.Reviewed by Cursor Bugbot for commit b58bd09. Bugbot is set up for automated code reviews on this repo. Configure here.