Merge upstream Modern.js updates - #9
Conversation
…ra-dev#8731) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: caohuilin <caohuilin@bytedance.com>
…#8733) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: caohuilin <caohuilin@bytedance.com>
…b-infra-dev#8730) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: caohuilin <caohuilin@bytedance.com>
…] (main) (web-infra-dev#8723) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: caohuilin <caohuilin@bytedance.com>
…rity] (main) (web-infra-dev#8722) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: caohuilin <caohuilin@bytedance.com>
…in) (web-infra-dev#8729) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…update-20260702 # Conflicts: # benchmark/bundle-diff/package.json # packages/cli/adapter-rstest/package.json # packages/cli/plugin-bff/package.json # packages/cli/plugin-data-loader/package.json # packages/cli/plugin-styled-components/package.json # packages/runtime/plugin-i18n/package.json # packages/runtime/plugin-image/package.json # packages/runtime/plugin-runtime/package.json # packages/server/bff-runtime/package.json # packages/server/create-request/package.json # packages/toolkit/create/package.json # packages/toolkit/plugin/package.json # packages/toolkit/sandpack-react/package.json # scripts/prebundle/package.json # scripts/rslib/package.json # scripts/rstest-config/setup.ts # tests/integration/image-component/package.json # tests/package.json
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59aa20eb97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ( | ||
| !process.features.typescript && | ||
| typeof nodeModule.stripTypeScriptTypes === 'function' | ||
| ) { |
There was a problem hiding this comment.
The repo still allows Node >=20, but this guard only installs the hooks when module.stripTypeScriptTypes exists, which is only available on newer Node 22+ releases. On Node 20/22.0-22.12, process.features.typescript is false and stripTypeScriptTypes is undefined, so the newly added server setup silently does nothing; packages/server/server/src/helpers/mock.ts then dynamically imports tests/fixtures/mock/*/config/mock/index.ts and still hits Node's unknown .ts extension. Please add a real fallback transformer for those supported Node versions or narrow the supported test/runtime gate.
Useful? React with 👍 / 👎.
…#9) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
4 participants
Summary
Verification
Note: main-ultramodern is checked out in another local worktree, so this update is prepared on automation/modern-js-update-20260702.