vscode: fix icons and .json files#214
Merged
KyrylR merged 2 commits intoBlockstreamResearch:masterfrom Feb 10, 2026
Merged
Conversation
Contributor
Author
|
cc @KyrylR |
There is an issue with displaying icons -- `icon-theme.json` counts as a separate icon theme, so other icons besides `simf` and `wit` didn't displayed. Also, I had removed activation of LSP for `.json` files, because it works on **all** jsons, which is not desired
gerau
force-pushed
the
vscode/fix-icons
branch
from
cb2e13b to
b3f07cd
Compare
Collaborator
|
Did you test it locally? |
Contributor
Author
Yeah, it's working fine on my side and showing the default icons and the new ones for If the issue persists after this fix, you should try changing the icon pack via |
Collaborator
We should mention this in the CHANGELOG.md |
KyrylR
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue with displaying icons --
icon-theme.jsoncounts as aseparate icon theme, so other icons besides
simfandwitdidn'tdisplayed.
Also, I had removed activation of LSP for
.jsonfiles, because itworks on all jsons, which is obviously not desired.