add modules support#1
Merged
Merged
Conversation
gerau
force-pushed
the
feat/modules-support
branch
5 times, most recently
from
ea58ef1 to
843bf67
Compare
gerau
force-pushed
the
feat/modules-support
branch
3 times, most recently
from
4d57f61 to
5a442a2
Compare
Collaborator
Author
|
bump version to 0.6.0 to match simplicityhl minor version |
gerau
force-pushed
the
feat/modules-support
branch
from
5a442a2 to
56a0a4a
Compare
gerau
force-pushed
the
feat/modules-support
branch
3 times, most recently
from
48e364c to
0620cb7
Compare
run cargo update psm --precise 0.1.28 to downgrade ar-archive-writer, so it would compile on rust 1.85
It's constantly throwing errors to an client if there are document are not builded, so it's better to silently fail here
gerau
force-pushed
the
feat/modules-support
branch
from
0620cb7 to
179f73c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially closes #2.
This PR does several things:
linearization_mapfield toDocumentso we can get info about functions from outside the given file.Document: move functions that perform operations with SimplicityHL Functions inside theDocumentimplementation, because it makes more sense and uses the newlinearization_map.jet::documentationbecause we already moved the documentation inside the compiler itself.Right now, all LSP functions are working except for references, because we need to find a way to support references from modules to the files that use these modules. Also, I think multi-file support could be done better.
Draft for now, because it uses a custom fork of SimplicityHL with public visibility of
DependencyMapandModule.