fix(isTypeScriptComponent): check all script tags (#933)

[milahu]

fix #933

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
mitosis-fiddle	✅ Ready (Inspect)	Visit Preview	Dec 2, 2022 at 4:27PM (UTC)

[raymondmuller]

@milahu Svelte doesn't support multiple <script> tags (with the exception of a script with context='module')

See example REPL: https://svelte.dev/repl/d5266c4fd50a49398b232ef54a825fdf?version=3.53.1
Issue and Explanation on the official Svelte repo: sveltejs/svelte#6387 (comment)

[raymondmuller]

The code seems to be also invalid.

[milahu]

thanks, return '' was missing

Svelte doesn't support multiple <script> tags (with the exception of a script with context='module')

example input
https://github.com/PuruVJ/macos-web/blob/main/src/components/Dock/DockItem.svelte
whats the meaning of context=module?
does it work with svelte2mitosis?

[raymondmuller]

thanks, return '' was missing

Svelte doesn't support multiple <script> tags (with the exception of a script with context='module')

example input https://github.com/PuruVJ/macos-web/blob/main/src/components/Dock/DockItem.svelte whats the meaning of context=module? does it work with svelte2mitosis?

The official Svelte docs explain context module scripts: https://svelte.dev/docs#component-format-script-context-module

Regarding if this is working in Sveltosis, not entirely yet.
Export statements are parsed, but there is still some work to do there for other node types.

I suggest closing this PR.

[milahu]

The official Svelte docs explain context module scripts: svelte.dev/docs#component-format-script-context-module

aah, so these are static variables of the component class
https://en.wikipedia.org/wiki/Static_variable#Object-oriented_programming

<script context="module"> is a confusing name, but well

I suggest closing this PR.

i suggest to throw NotImplementedError

currently <script context="module"> is ignored, see mitosis fiddle
but maybe the fiddle is outdated