Merged
Conversation
kjnam
approved these changes
Mar 11, 2026
Member
kjnam
left a comment
kjnam
left a comment
There was a problem hiding this comment.
As we discussed, the PR looks good. Some minor style changes and more tests will be added later.
Collaborator: Kijin Nam<kijin.nam@water.ca.gov> DSM2-1191
subroutine get_chan_ec_val is duplicated with function chan_ec_val
temporary branch
DSM2-1306
centroid elevation should be calculated instead of centroid depth DSM2-1306
Fixed the calculation of centroid of cross section at each elevation DSM2-1306
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch includes the following main changes: