Add Engine abstraction to enable multiple backends - #26
Open
ryanorendorff wants to merge 1 commit into
Open
Conversation
This PR introduces the `Engine` abstract class, which allows for separating out the host side computation from the specific backend used to accelerate certain computations. This should enable - Building with just the CPU to test out that the API works as expected but - Introducing new backends like Metal - Distinction of what is host side computation versus what is engine specific.
Collaborator
|
Hi! I've been looking at this for some time and I agree is a good idea to include some sort of backend abstraction. I am in the process of refining this, as we think it could be more appropiate to have this kind of abstraction at a lower level inside FIDESlib, so other compute backends such as Metal as you mentioned can be more easily implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
Engineabstract class, which allows for separating out the host side computation from the specific backend used to accelerate certain computations. This should enableThis PR moves code around, it does not introduce new algorithmic code.