Skip to content

Add TLS keylog support#520

Merged
michalvasko merged 3 commits intoCESNET:develfrom
Roytak:devel
Nov 15, 2024
Merged

Add TLS keylog support#520
michalvasko merged 3 commits intoCESNET:develfrom
Roytak:devel

Conversation

@Roytak
Copy link
Copy Markdown
Collaborator

@Roytak Roytak commented Nov 15, 2024

No description provided.

Comment thread src/session_server_tls.c Fixed
Comment thread src/session_server_tls.c Fixed
Comment thread src/session_server.c
return;
}

server_opts.tls_keylog_file = fopen(keylog_file_name, "a");

Check failure

Code scanning / CodeQL

File created without restricting permissions

A file may be created here with mode 0666, which would make it world-writable.
Comment thread src/session_server.c
return;
}

server_opts.tls_keylog_file = fopen(keylog_file_name, "a");

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This argument to a file access function is derived from [user input (an environment variable)](1) and then passed to fopen(__filename).
@michalvasko michalvasko merged commit b61032e into CESNET:devel Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants