Jimmyfagan/bb 4361 remove inflight dependency#80
Merged
Conversation
bwang-icf
approved these changes
Jan 22, 2026
Contributor
bwang-icf
left a comment
There was a problem hiding this comment.
I was able to locally verify that things work as expected and from this stack overflow answer (https://stackoverflow.com/questions/15806152/how-do-i-override-nested-npm-dependency-versions) it seems that this is the right way for overrides to be handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-4361
What Does This PR Do?
Removes an unused dependency (which had a sub-dependency of
inflight, and added an override forinflightsince it was subdependency of another library which wasn't clear how to trivially remove/replace.What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Validation
Run
yarn testto test the sdk in isolation. Follow steps at https://github.com/CMSgov/cms-bb2-node-sdk/blob/0c19361e16e664df033a8ef56cdad8b0f51066b8/README-sdk-dev.md#:~:text=Consuming%20from%20the%20sample%20client to run a local sample client with this version of the SDK and confirm that everything works as expected.What Security Implications Does This PR Have?
Please indicate if this PR does any of the following: