Skip to content

Add conditional drop_vars execution#586

Merged
Zeitsperre merged 2 commits intomainfrom
fix-notebooks
Mar 11, 2026
Merged

Add conditional drop_vars execution#586
Zeitsperre merged 2 commits intomainfrom
fix-notebooks

Conversation

@Zeitsperre
Copy link
Member

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Adds a conditional drop_vars call so that legacy environments continue to function

Does this PR introduce a breaking change?

No.

Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@Zeitsperre Zeitsperre requested a review from huard March 11, 2026 17:15
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the docs label Mar 11, 2026
@Zeitsperre Zeitsperre requested a review from tlogan2000 March 11, 2026 19:28
@Zeitsperre
Copy link
Member Author

PVI @fmigneault

@tlogan2000
Copy link
Collaborator

@Zeitsperre possiblly use drop_vars(errors='ignore') ? I'm not sure which is better really. Yours is more explicit i guess

Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@Zeitsperre Zeitsperre enabled auto-merge March 11, 2026 19:52
@Zeitsperre Zeitsperre merged commit c26924e into main Mar 11, 2026
22 checks passed
@Zeitsperre Zeitsperre deleted the fix-notebooks branch March 11, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notebook output error in CI

2 participants