Cookiecutter update, GIS testing adjustments#589
Open
Zeitsperre wants to merge 15 commits intomainfrom
Open
Conversation
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Contributor
|
Note It appears that this Pull Request modifies the On inspection, the No further action is required. |
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
huard
approved these changes
Mar 13, 2026
Collaborator
huard
left a comment
huard
left a comment
There was a problem hiding this comment.
Thanks Trevor for the clean-up, much appreciated.
I'll just want to confirm with James that changes in outputs are expected from the Raven update.
Comment on lines
+606
to
618
| "0.227657", # NASH_SUTCLIFFE "0.253959", # FIXME: RHF v4.12 new value: "0.227657" | ||
| "-17.5132", # PCT_BIAS "-17.0904", # FIXME: RHF v4.12 new value: "-17.5132" | ||
| "0.405353", # KLING_GUPTA "0.443212", # FIXME: RHF v4.12 new value: 0.405353 | ||
| ] | ||
|
|
||
| # FIXME: RHF 4.12: Many of these values are no longer valid | ||
| for d, q_sim in [ | ||
| (0, 85.92355875229545), | ||
| (1000, 74.05569855818379), | ||
| (2000, 62.675159400333115), | ||
| (3000, 42.73584909530037), | ||
| (4000, 128.70284018326998), | ||
| (1000, 70.7391269200262), # FIXME: Previously: 74.05569855818379 | ||
| (2000, 65.24225415070816), # FIXME: Previously: 62.675159400333115 | ||
| (3000, 45.2727362517773), # FIXME: Previously: 42.73584909530037 | ||
| (4000, 127.63921091228055), # FIXME: Previously: 128.70284018326998 | ||
| ]: |
Collaborator
There was a problem hiding this comment.
@analytophile Could you confirm that outputs from the routing emulator are expected to vary following the recent Raven update ?
Member
Author
There was a problem hiding this comment.
@huard This test was not enabled for quite some time. It is very possible that the values here reflect changes from an earlier RHF (3.8, 4.1, etc.). Model expected outputs have shifted in other tests as well during that time.
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
dependency-groups)pre-commitwithprektoxDoes this PR introduce a breaking change?
Yes. The
devanddocsinstall recipes are no longer available from thesdistandwheeldistributions. These recipes are specifically for developers and are now only accessible when examining the source code.ravenpy[gis,raven-hydro]remain as valid install recipes.Other information:
https://peps.python.org/pep-0735/
https://prek.j178.dev/