Fix Windows x86 calling convention mismatch for HPDF error handler#12
Merged
Conversation
Co-authored-by: Cadons <43477517+Cadons@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update docraft polygon parser for improved performance
Fix Windows x86 calling convention mismatch for HPDF error handler
Mar 15, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows x86 with
-DHPDF_DLL,HPDF_Error_Handleris typedef'd withHPDF_STDCALL(__stdcall), buterror_handlerwas declared with the default__cdecl, causing a hard compile error when passing it toHPDF_New. This is a no-op on x64 where the two conventions are unified.Change
HPDF_STDCALLto theerror_handlerfunction definition indocraft_haru_backend.ccso its type exactly matchesHPDF_Error_Handler:HPDF_STDCALLis already defined byhpdf_types.h— expands to__stdcallon x86 Windows withHPDF_DLL, empty string everywhere else.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.