Skip to content

Conversation

@rkalis
Copy link
Member

@rkalis rkalis commented Dec 16, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 16, 2025 09:23
@vercel
Copy link

vercel bot commented Dec 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
cashscript Ready Ready Preview, Comment Dec 16, 2025 9:30am

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.21%. Comparing base (e2e12ba) to head (6592b97).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #377       +/-   ##
===========================================
- Coverage   99.54%   87.21%   -12.34%     
===========================================
  Files           8       48       +40     
  Lines         222     3276     +3054     
  Branches       10      593      +583     
===========================================
+ Hits          221     2857     +2636     
- Misses          1      329      +328     
- Partials        0       90       +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the vitest configuration to properly support code coverage collection across the monorepo packages. The main issue being addressed is that the previous root: './test' setting was causing incorrect path resolution for both test discovery and coverage reporting.

Key Changes:

  • Removed root: './test' from all package vitest configs and updated paths accordingly
  • Added explicit coverage.include patterns to ensure only source files in src/ are measured for coverage
  • Fixed import path in cashscript's vitest.setup.ts from relative-to-test-dir to relative-to-package-root

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/utils/vitest.config.ts Removed root setting, updated test include pattern to test/**/*, added coverage include pattern, removed coverage reporter config
packages/cashscript/vitest.setup.ts Fixed TestExtensions import path from '../src/test/...' to './src/test/...' to work with new root setting
packages/cashscript/vitest.config.ts Removed root setting, updated test include pattern to test/**/*, added coverage include pattern, reordered config fields
packages/cashc/vitest.config.ts Removed root setting, updated test include pattern to test/**/*, added coverage include and exclude patterns for generated grammar files, reordered config fields

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rkalis rkalis merged commit 894e90c into master Dec 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants