CATROID-1647 Feat: Resize and rotate object when placing in stage by harshsomankar123-tech · Pull Request #5189 · Catrobat/Catroid

harshsomankar123-tech · 2026-04-07T06:42:42Z

Related Jira Ticket

(https://catrobat.atlassian.net/browse/CATROID-1647)

Summary

This PR introduces multi-touch support to the VisualPlacementActivity, allowing users to intuitively resize and rotate a sprite while positioning it on the stage.

To provide clear visual feedback, a new bounding box overlay with corner handles has been implemented. Additionally, the IDE now automatically handles data persistence by inserting SetSizeToBrick and PointInDirectionBrick into the sprite's script upon confirmation, streamlining the creation workflow.

Technical Changes

ResizeRotateGestureDetector.kt: New gesture detector for handling pinch-to-scale and two-finger rotation math.
BoundingBoxOverlay.kt: Custom View that draws a dynamic blue outline and curved-arrow handles around the active sprite.
VisualPlacementTouchListener.java: Updated to coordinate between single-finger dragging and multi-finger transformations.
TransformationInterface.kt: Extends the existing interface to include scale and rotation setters.
ProjectActivity.kt: Added logic to automatically append the relevant bricks to the script based on the visual placement results.

Screen Recording

Screenrecorder-2026-04-07-15-56-57-229.mp4

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

…cement

…Stage

…ate feature (IDE-217)

… in ProjectActivity.kt (IDE-217)

… (IDE-217)

…-217)

…rCloud Reliability bug (IDE-217)

Copilot

Pull request overview

This PR adds multi-touch transformation support to the visual placement flow so users can resize and rotate a sprite while placing it on the stage, with a bounding-box overlay for visual feedback and persistence of the result back into the project.

Changes:

Introduces a new two-finger gesture detector for pinch-to-scale and rotation, and integrates it into visual placement touch handling.
Adds a bounding box overlay view (with corner-handle vector drawable) that updates during placement interactions.
Persists placement scale/rotation back to the calling activities and (for new sprites) appends corresponding bricks to the generated script.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
catroid/src/main/java/org/catrobat/catroid/visualplacement/ResizeRotateGestureDetector.kt	New detector for scaling/rotation math and gesture state.
catroid/src/main/java/org/catrobat/catroid/visualplacement/BoundingBoxOverlay.kt	New overlay view rendering a rotated bounding box + handles around the placed sprite.
catroid/src/main/res/drawable/ic_corner_handle.xml	New corner-handle vector drawable used by the overlay.
catroid/src/main/java/org/catrobat/catroid/visualplacement/VisualPlacementTouchListener.java	Adds multi-touch routing and overlay updates in the touch pipeline.
catroid/src/main/java/org/catrobat/catroid/visualplacement/VisualPlacementActivity.java	Wires detector + overlay into placement UI and returns scale/rotation via result extras.
catroid/src/main/java/org/catrobat/catroid/visualplacement/TransformationInterface.kt	Extends placement callback contract to include scale/rotation setters.
catroid/src/main/java/org/catrobat/catroid/ui/SpriteActivity.java	Applies returned scale/rotation from visual placement to the current sprite look.
catroid/src/main/java/org/catrobat/catroid/ui/ProjectActivity.kt	For new sprites, creates a StartScript and appends PlaceAt/SetSize/PointInDirection bricks from placement results.
catroid/src/test/java/org/catrobat/catroid/test/visualplacement/ResizeRotateGestureDetectorTest.kt	Unit tests for detector helper math and initial state.
catroid/src/test/java/org/catrobat/catroid/test/visualplacement/VisualPlacementResizeRotateTest.kt	Tests for integration expectations (drag still works, overlay update, detector state).
catroid/src/test/java/org/catrobat/catroid/test/visualplacement/VisualPlacementTouchListenerTest.java	Updates mocks for new pointer-count logic.
catroid/src/test/java/org/catrobat/catroid/test/visualplacement/VisualPlacementPositionCorrectionTest.java	Updates mocks for new pointer-count/pointer-id checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…entActivity.java

wslany

Thanks for the feature. I found a couple of interaction edge cases around rotation handling and the transition back from multi-touch to single-touch, plus two smaller cleanup items. The generated APK builds and the focused visual-placement unit tests pass locally, but I think the P2 items should be fixed before merge.

…uch baseline reset, and direction comparison; update copyrights and merge nested ifs

wslany

Thanks for the quick follow-up. I still see a couple of actionable issues in the latest head, mainly around the pointer-up reset path and missing regression coverage for the review fixes.

- Resolved P2 issue in VisualPlacementTouchListener where pointer-up events caused stale touch baselines. - Removed unused DEFAULT_ROTATION in ProjectActivity and fixed default rotation extra read. - Added regression tests for angle normalization and multi-touch transition resets.

wslany

One remaining coverage request: we want full coverage for new behavior from now on. The focused unit coverage improved for the gesture/touch code, but the activity result/script-creation path still lacks direct regression coverage.

…E-217)

…ton (IDE-217) - Fix SpriteActivity: default placementRotation to DEGREE_UI_OFFSET (90°) and only apply rotation when changed - Fix VisualPlacementActivity: set correct defaults for rotationMode and initialLookRotation when loading from look list - Fix default initialSpriteRotation to DEGREE_UI_OFFSET to prevent unwanted PointInDirectionBrick - Add ScreenValueHandler.updateScreenWidthAndHeight() for correct layout sizing - Use existing LayoutParams instead of creating new ones - Add two-finger panning with frame-to-frame delta tracking - Add velocity-based rotation snapping to 90° increments - Add Reset toolbar button to restore initial transformations

+    private var lastRotationTime: Long = 0
+    private var lastRotationAngle: Float = 0f
+
+    fun onTouchEvent(event: MotionEvent): Boolean {


+    }
+
+    private fun getSnappedAngle(angle: Float): Float {
+        val normalizedRotation = (angle % 360 + 360) % 360


+    }
+
+    private fun getSnappedAngle(angle: Float): Float {
+        val normalizedRotation = (angle % 360 + 360) % 360


+    }
+
+    private fun getSnappedAngle(angle: Float): Float {
+        val normalizedRotation = (angle % 360 + 360) % 360


+
+    private fun getSnappedAngle(angle: Float): Float {
+        val normalizedRotation = (angle % 360 + 360) % 360
+        val snapAngles = floatArrayOf(0f, 90f, 180f, 270f, 360f)


+
+    private fun getSnappedAngle(angle: Float): Float {
+        val normalizedRotation = (angle % 360 + 360) % 360
+        val snapAngles = floatArrayOf(0f, 90f, 180f, 270f, 360f)


+
+    private fun getSnappedAngle(angle: Float): Float {
+        val normalizedRotation = (angle % 360 + 360) % 360
+        val snapAngles = floatArrayOf(0f, 90f, 180f, 270f, 360f)


+
+    private fun getSnappedAngle(angle: Float): Float {
+        val normalizedRotation = (angle % 360 + 360) % 360
+        val snapAngles = floatArrayOf(0f, 90f, 180f, 270f, 360f)


- Add ic_rotate_90 drawable (circular arrow icon) - Add rotate_90 menu item between reset and confirm - Implement rotateBy90Degrees() in VisualPlacementActivity - Add rotate_90 string resource - Add testCumulativeRotationForRotate90Feature test - Add testSetCumulativeRotationAndScaleForResetScenario test - Update test listeners to implement onPan interface

sonarqubecloud · 2026-04-14T21:41:18Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

 			case R.id.confirm:
 				finishWithResult();
 				break;
+			case R.id.reset:


+			case R.id.reset:
+				resetTransformations();
+				break;
+			case R.id.rotate_90:


harshsomankar123-tech added 2 commits April 7, 2026 05:01

[RED] IDE-217: Add tests and boilerplate for resize/rotate visual pla…

13014f3

…cement

[GREEN] IDE-217: Implement resize/rotate logic and visual overlay in …

488d5d4

…Stage

github-advanced-security AI found potential problems Apr 7, 2026

View reviewed changes

harshsomankar123-tech marked this pull request as draft April 7, 2026 06:46

github-advanced-security AI found potential problems Apr 7, 2026

View reviewed changes

Fix: SonarCloud reliability and Android Lint issues in Resize and rot…

5ea9465

…ate feature (IDE-217)

github-advanced-security AI found potential problems Apr 7, 2026

View reviewed changes

harshsomankar123-tech added 3 commits April 7, 2026 14:50

Fix: detekt unused imports, missing braces and SonarCloud reliability…

f136b81

… in ProjectActivity.kt (IDE-217)

Fix: All SonarCloud reliability and detekt issues in Visual Placement…

e3302f4

… (IDE-217)

Refactor: Final SonarCloud reliability and maintainability fixes (IDE…

a2eca52

…-217)

github-advanced-security AI found potential problems Apr 7, 2026

View reviewed changes

Comment thread catroid/src/main/java/org/catrobat/catroid/visualplacement/VisualPlacementActivity.java Fixed

Comment thread catroid/src/main/java/org/catrobat/catroid/visualplacement/VisualPlacementActivity.java Fixed

Fix: Rename rotation field in VisualPlacementActivity to resolve Sona…

4681503

…rCloud Reliability bug (IDE-217)

harshsomankar123-tech marked this pull request as ready for review April 7, 2026 10:29

harshsomankar123-tech requested a review from wslany April 7, 2026 15:43

harshsomankar123-tech added the Active Member Tickets that are assigned to members that are still currently active label Apr 8, 2026

harshsomankar123-tech requested a review from dorianpercic April 10, 2026 12:08

wslany requested a review from Copilot April 10, 2026 13:02

Copilot started reviewing on behalf of wslany April 10, 2026 13:02 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Fix bugs in ProjectActivity.kt, SpriteActivity.java, and VisualPlacem…

d039f50

…entActivity.java

wslany changed the title ~~IDE-217 Feat: Resize and rotate object when placing in stage~~ CATROID-1647 Feat: Resize and rotate object when placing in stage Apr 11, 2026

wslany requested changes Apr 12, 2026

View reviewed changes

Address PR Catrobat#5189 review comments: fix angle normalization, to…

9dc9c3d

…uch baseline reset, and direction comparison; update copyrights and merge nested ifs

github-advanced-security AI found potential problems Apr 12, 2026

View reviewed changes

Comment thread catroid/src/main/java/org/catrobat/catroid/visualplacement/ResizeRotateGestureDetector.kt Fixed

Comment thread catroid/src/main/java/org/catrobat/catroid/visualplacement/ResizeRotateGestureDetector.kt Fixed

Fix detekt bot warning and SonarQube code smell

21a2c27

wslany requested changes Apr 12, 2026

View reviewed changes

harshsomankar123-tech requested a review from wslany April 12, 2026 17:28

Remove unused local variable in VisualPlacementTouchListener

12275b1

wslany requested changes Apr 14, 2026

View reviewed changes

Comment thread catroid/src/main/java/org/catrobat/catroid/ui/ProjectActivity.kt Outdated

harshsomankar123-tech added 2 commits April 14, 2026 15:20

Add regression unit tests for visual placement in ProjectActivity (ID…

6f79f9e

…E-217)

github-advanced-security AI found potential problems Apr 14, 2026

View reviewed changes

Comment thread catroid/src/main/java/org/catrobat/catroid/visualplacement/VisualPlacementActivity.java Fixed

github-advanced-security AI found potential problems Apr 14, 2026

View reviewed changes

Conversation

harshsomankar123-tech commented Apr 7, 2026 • edited by wslany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Jira Ticket

Summary

Technical Changes

Screen Recording

Your checklist for this pull request

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wslany left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wslany left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wslany left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Apr 14, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

harshsomankar123-tech commented Apr 7, 2026 •

edited by wslany

Loading