Skip to content

CATROID-1555: REFACTOR tests of WaitForSoundAction to Kotlin#5191

Open
harshsomankar123-tech wants to merge 1 commit intoCatrobat:developfrom
harshsomankar123-tech:CATROID-1555-refactor-waitforsoundaction-tests-kotlin
Open

CATROID-1555: REFACTOR tests of WaitForSoundAction to Kotlin#5191
harshsomankar123-tech wants to merge 1 commit intoCatrobat:developfrom
harshsomankar123-tech:CATROID-1555-refactor-waitforsoundaction-tests-kotlin

Conversation

@harshsomankar123-tech
Copy link
Copy Markdown
Member

@harshsomankar123-tech harshsomankar123-tech commented Apr 9, 2026

Jira Ticket: https://catrobat.atlassian.net/browse/CATROID-1555

Description

This PR refactors WaitForSoundActionTest from Java to Kotlin. This is part of the ongoing effort to modernize the codebase and improve null safety across the project.

Changes:

  • Deleted: WaitForSoundActionTest.java
  • Created: WaitForSoundActionTest.kt (Refactored implementation)

Testing:

  • Verified that the new implementation follows idiomatic Kotlin patterns.
  • Verified that all lateinit variables are properly initialized in the setup phase.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants