180 기능 cli 실행 옵션을 UI에서 통합 관리하도록 개선#187
Merged
Conversation
ParkGyeongTae
approved these changes
Oct 4, 2025
Contributor
ParkGyeongTae
left a comment
There was a problem hiding this comment.
👍 완전 좋네여! 잘동작합니다~!
interface/core/config/__init__.py
Outdated
| DEFAULT_VECTORDB_TYPE, | ||
| DEFAULT_VECTORDB_LOCATION, | ||
| load_config, | ||
| _get_session_value, |
Contributor
There was a problem hiding this comment.
💊 _ 접두사 함수의 경우 클래스 내에서만 선언된 경우 클래스 내에서만 private하게 사용, 파일에서 함수만 선언된 경우 해당 파일에서만 사용하는 것으로 추후에 개선할 수 있을 것 같아요~!
Collaborator
Author
There was a problem hiding this comment.
👍 좋은 지적 감사합니다! 초기에 하나의 파일로 구현하고 쪼개다 보니 기존 함수명을 그대로 들고와서, 불필요한 import를 제거하고 함수명을 업데이트 했습니다. f25e897
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
📝 요약(Summary)
💬 To Reviewers (선택)
설정 페이지 제공
사이드바 에서 설정 선택
PR Checklist
uv run lang2sql run-streamlit -p 8888로 실행 후 동작 확인reference) How to Code Review