refactor: utils 모듈 구조 개선 및 디렉토리 통합#189
Merged
ParkGyeongTae merged 3 commits intomasterfrom Oct 6, 2025
Merged
Conversation
ehddnr301
requested changes
Oct 6, 2025
Collaborator
ehddnr301
left a comment
There was a problem hiding this comment.
👍 전체적으로 좋은 방향성이라고 생각됩니다아!
❗일부 변경이 필요한 지점이 보이는것같은데 확인부탁드립니다아!
| finally: | ||
| try: | ||
| cursor.close() | ||
| except e: |
Collaborator
There was a problem hiding this comment.
❗요부분 Exception 처리가 조금 이상한듯 합니다아!
- Trino 는 현재 에러는 발생하지 않는데 그냥 단순 문법확인차원 입니다아. cursor.close() 동작시에 에러가 발생해야만 문법에러가 발생할듯 하네요!
utils/databases/factory.py
Outdated
| try: | ||
| module_name = f"utils.databases.connector.{db_type}_connector" | ||
| module = importlib.import_module(module_name) | ||
| connector_class = getattr(module, f"{db_type.capitalize()}Connector") |
Collaborator
There was a problem hiding this comment.
❗이 부분이 capitalize() 로 처리하게되면 ClickHouseConnector, Duckdb 같은 케이스를 커버하지 못할것으로 보입니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
📝 요약(Summary)
data_utils/,db_utils/디렉토리를utils/디렉토리로 통합하여 모듈 구조를 개선했습니다.utils.네임스페이스로 변경하여 일관성을 확보했습니다.💬 To Reviewers (선택)
utils/디렉토리 구조가 논리적으로 잘 구성되었는지 확인 부탁드립니다.PR Checklist
reference) How to Code Review