Skip to content

Conversation

@Clav12
Copy link

@Clav12 Clav12 commented Oct 24, 2022

Original commit ProjectBlaze/frameworks_base@79d5f2e

The home button stock aosp of the navbar with buttons is really ugly, better that of google pixels.

joeyhuab and others added 30 commits October 17, 2022 22:57
* Also only set featuresPixel to true by default.

Signed-off-by: Hưng Phan <[email protected]>
[SuperDroidBond: What's the use of it when we have a toggle to take care of it]

Signed-off-by: SuperDroidBond <[email protected]>
Change-Id: Ib2444f91cdba9973dc3142bba8cf6d349e983c8b
Partially reverts commit 8dfd6b7.
In some rare cases, can hit this NPE.

10-09 12:32:52.244  2316  2316 E AndroidRuntime: FATAL EXCEPTION: main
10-09 12:32:52.244  2316  2316 E AndroidRuntime: Process: com.android.systemui, PID: 2316
10-09 12:32:52.244  2316  2316 E AndroidRuntime: java.lang.NullPointerException: Attempt to get length of null array
10-09 12:32:52.244  2316  2316 E AndroidRuntime: 	at java.util.Set.of(Set.java:692)
10-09 12:32:52.244  2316  2316 E AndroidRuntime: 	at com.android.settingslib.net.DataUsageUtils.getNormalizedMobileTemplate(DataUsageUtils.java:67)
10-09 12:32:52.244  2316  2316 E AndroidRuntime: 	at com.android.settingslib.net.DataUsageUtils.getMobileTemplate(DataUsageUtils.java:57)
10-09 12:32:52.244  2316  2316 E AndroidRuntime: 	at com.android.settingslib.net.DataUsageController.getDailyDataUsageInfo(DataUsageController.java:109)
10-09 12:32:52.244  2316  2316 E AndroidRuntime: 	at com.android.systemui.qs.QSFooterView.setUsageText(QSFooterView.java:117)
10-09 12:32:52.244  2316  2316 E AndroidRuntime: 	at com.android.systemui.qs.QSFooterView.setNoSims(QSFooterView.java:184)
10-09 12:32:52.244  2316  2316 E AndroidRuntime: 	at com.android.systemui.qs.QSFooterViewController$2.setNoSims(QSFooterViewController.java:73)
10-09 12:32:52.244  2316  2316 E AndroidRuntime: 	at com.android.systemui.statusbar.connectivity.CallbackHandler.handleMessage(CallbackHandler.java:84)
10-09 12:32:52.244  2316  2316 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:106)
10-09 12:32:52.244  2316  2316 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:201)
10-09 12:32:52.244  2316  2316 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:288)
10-09 12:32:52.244  2316  2316 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:7898)
10-09 12:32:52.244  2316  2316 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
10-09 12:32:52.244  2316  2316 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
10-09 12:32:52.244  2316  2316 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Change-Id: Ib5ab5da259a80b7f1e3a12b0c8a5078eb976fd20
Signed-off-by: minaripenguin37 <[email protected]>
Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
With dynamic Monet themes, most of the UI has at least a small amount
of color (chroma), so pure white stands out as the sole outlier (e.g.
Settings search bar in light mode). Use the 99% lightness shade instead
to improve consistency.

Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
…ckground

This matches the stock Pixel style and makes progress bars look more
integrated, since the active (foreground) part is using the accent
color.

Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Fix permission issues for network update service command-line commands
used in tests.

Bug: 251726675
Test: atest android.os.cts.SystemClockSntpTest
Merged-In: I8a34c801d82c769fd8d06e5b0b3177ce92b5f072
Change-Id: I8a34c801d82c769fd8d06e5b0b3177ce92b5f072
Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
When quickly click the bluetooth tile to switch the state, sometimes,
the state switch to "ON", but state.secondaryLabel is empty,
so secondary.visibility will set to "GONE".

Bug:
Test:
1. Drag down the tile bar
2. Select "bluetooth" and quickly turn it to on/off.
3. Repeat turn on and off many times.

Change-Id: I711631da36f8a9a80d2112670e32cc580db78cbf
Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Also includes:

  From: DennySPB <[email protected]>
  Date: Fri, 17 May 2019 09:49:23 +0300
  Subject: [PATCH] SmartCharging: Rework and add more customizations

  From: Pranav Vashi <[email protected]>
  Date: Thu, 16 Jan 2020 01:30:38 +0530
  Subject: [PATCH] Add config to make Smart Charging available on device

  From: xNombre <[email protected]>
  Date: Thu, 19 Aug 2021 23:25:28 +0200
  Subject: [PATCH] SmartCharging: Make sure resume level is lower than suspend level

    Braindead settings fragment or end-user (you can choose) can set
    resume level higher than suspend level. This is obviously wrong.

    This causes Android to write suspend and resume commands very
    frequently and quickly, this can cause phone crashes due to
    improper locking in the kernel. Such issue was reported to me.

    I am definitely not fixing the setting tile so let's come up with
    an easier approach - not resuming charging if level is mistakenly
    set. This won't kill shitty qcom kernel any more.

    Bonus: simplified if condition

  Signed-off-by: xNombre <[email protected]>

Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
* Required for smart charging
* Rewrite for A13

Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Revert "QS Tile: Make QS Ripple animation more prominent"

This reverts commit 48a396f.

Revert "QS Tile: Set ripple color to accent by default"

This reverts commit a31c216.

Revert "QSTile: More slower & Gradual QS Fade-in/out animation"

This reverts commit b00302b.

Revert "System shapes: Add Rounded outline shapes"

This reverts commit 0bc17a9.

Revert "[SQUASH]: Improve system shapes"

This reverts commit 8395739.

Revert "overlay: Update Icon shapes for System shapes feature"

This reverts commit 4707b8e.

Revert "base: Expose more UI elements for System shapes"

This reverts commit d7b2dc9.

Revert "base: Relax rounded corners"

This reverts commit d165717.

Revert "SystemUI: Toggle-able Translucent QS style [1/2]"

This reverts commit 2355f16.

Signed-off-by: Hưng Phan <[email protected]>

Revert "SystemUI: Link auto brightness background to corner radius"

This reverts commit 6cef759.

Revert "BrightnessController: update icon state for auto bg icon"

This reverts commit c92b4dc.

Revert "System: Expose brightness slider tunables for theming"

This reverts commit 4fca803.

Revert "core: Link all corner radius dimens to `config_dialogCornerRadius`"

This reverts commit bc72bae.

Revert "SystemUI: Improve vertical QS tile layout & animation"

This reverts commit 2a07cd4.

Revert "SystemUI: Don't confuse rotation with orientation"

This reverts commit ffe1aca.

Revert "SystemUI: Fixes/Improvements for QS tiles count settings"

This reverts commit d674ff0.

Revert "SystemUI: Stop using marquee on qs tile labels"

This reverts commit 09b979d.

Revert "SystemUI: Cleanup QS tile count settings"

This reverts commit d791c19.

Revert "SystemUI: Fix qs customizer corner radius"

This reverts commit d1d98d9.

Revert "SystemUI: Reduce qs tile padding"

This reverts commit 09a1b90.

Revert "TileAdapter: Report 3 columns for qs customizer"

This reverts commit ea45528.

Revert "SystemUI: Fix wrong context for mNumColumns"

This reverts commit 78e9939.

Revert "SystemUI: Adapt DotOs qs tile changes for qs tile count settings"

This reverts commit f2a16d1.

Signed-off-by: Hưng Phan <[email protected]>

Revert "QS tile count settings: Fixes and improvements for landscape settings"

This reverts commit 79298d7.

Signed-off-by: Hưng Phan <[email protected]>

Revert "SystemUI: QS tile count settings code fixup"

This reverts commit 6943d2a.

Revert "SystemUI: Increase QS tile corner radius"

This reverts commit ed502b6.

Revert "SystemUI: Improve QS tile count settings"

This reverts commit fdb094d.

Revert "SystemUI: Refactor qs tile count settings"

This reverts commit 8e2e1e0.

Signed-off-by: Hưng Phan <[email protected]>

Revert "SystemUI: Fix qs tile vertical layout scrolling"

This reverts commit 86a31ac.

Revert "[1/2] SystemUI: qs hide label setting"

This reverts commit b3d9895.

Revert "[1/2] SystemUI: qs columns count settings"

This reverts commit 3700780.

Signed-off-by: Hưng Phan <[email protected]>

Revert "SystemUI: add OmniSettingService Hooks"

This reverts commit b8117bd.
Change-Id: I5b5981fe183074c43b625ef3202f58c7635f0377
Signed-off-by: LordShenron <[email protected]>
Signed-off-by: Aryan Sinha <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
QSPanel: Design changes

* Switch to rounded rectangular tiles
* Slim designed brightness bar

Signed-off-by: StarkDroid <[email protected]>
Signed-off-by: str-br <[email protected]>

Add QS Panel Styles [1/3]

Note for other roms:
This is the jankiest possible implementation that DOES WORK but is more of an extra work.
Ideally i'd like to have this implemented within in-line ThemeOverLayApplier and ThemeOverlayController but rather
its being handled through settings with a custom observer at the moment to trigger the overlays.

So why this impl?
I was just curious to test this out, but once i saw that its implemented and is working, i decided to push it and work on the refinement later

Feel free to do the refinement on your end if you are able to :D

Signed-off-by: StarkDroid <[email protected]>

Partial Revert "QSPanel: Design changes"

Prepping this for QS Panel Styles

This reverts commit ef0c7cabca565e8ff4b2f24d5023c8ce9d51f030.

QSTile: More slower & Gradual QS Fade-in/out animation

Signed-off-by: StarkDroid <[email protected]>

QS Tile: Set ripple color to accent by default

Signed-off-by: StarkDroid <[email protected]>

QS Tile: Make QS Ripple animation more prominent

Signed-off-by: StarkDroid <[email protected]>
Signed-off-by: str-br <[email protected]>

QS Panel: Add Two-Tone Accented QS Style [1/3]

Inspired by Fluid-UI's QS Panel changes

Signed-off-by: Trishiraj <[email protected]>

QS Styles: Add QS tiles color pop [1/2]

Signed-off-by: Trishiraj <[email protected]>

QSPanel Styles: Add key into backup and validator

Signed-off-by: Trishiraj <[email protected]>
Signed-off-by: str-br <[email protected]>

QS Style: Make Outline QS Style truly outline

Signed-off-by: Trishiraj <[email protected]>
Signed-off-by: str-br <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
@neobuddy89:
* Removed unused configs and imports
* De-omnify with TunerService and TileUtils

Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
* singleLine forces scrollHorizontally, which doesnt go along with gravity="center"

Signed-off-by: minarypenguin <[email protected]>
Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: str-br <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
* Do not let every tom, dick and harry set max columns.
* On config changes and settings update, check if dynamic row and columns update.
* Update resources in tile layout when orientation changes to get proper tiles in landscape.
* Request layout changes whenever column update happens.
* Be smart in calculating how many max tiles should Quick QS show depending on no. of columns.

Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: str-br <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
* This fixes AOSP bug by matching radius in qs_customizer_background_primary
  and qs_customizer_background_transition

Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
* Useful when using more than default columns.

Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
* it is very expensive for grid types of views (considering we have qs tiles count settings), especially when animating the QS panel expansion.

Signed-off-by: str-br <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
* follow the activity background color (n50 & n900) to make it look like transparent when swiping on an empty/no-text area.

Signed-off-by: str-br <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
* for system shapes to be effective

Signed-off-by: str-br <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
* just like realme ui brighness slider

Signed-off-by: dlwlrma123 <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Signed-off-by: str-br <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
StarkDroid and others added 20 commits November 18, 2022 17:37
This commit does not require any WeatherJaw commits in FWB or adding back weather parts.
Am Keeping Google's Weather Slice for lockscreen weather.

Special Thanks to @omnirom for the OmniJawsClient and services package
@/AICP for their statusbar weather base code adapted for QS Panel and A11
Ref: https://gerrit.aicp-rom.com/c/AICP/frameworks_base/+/49630

@S/tarkDroid: Forward and align it with A12 QS Header

Signed-off-by: Trishiraj <[email protected]>
Change-Id: Iafa109a166a6c4106b15c4bff4dfd322718bed84
str: adjust paddings
Signed-off-by: str143 <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Signed-off-by: str143 <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Co-authored-by: Trishiraj <[email protected]>
Signed-off-by: str143 <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Change-Id: I834f3436dbd89c4019d84eb9aff76a115fb32676
Signed-off-by: Hưng Phan <[email protected]>
* switch to config_bodyFontFamily  instead of using monospace
* dynamically apply font style to lockscreen for fonts with mixed structure like ndot (combination of roboto and nothing dont font)
* nothing font exclusive: adjust clock color based from spacewar
* dynamiccaly adjust line spacing for custom/broken fonts to prevent overlapping
* make large clock view biased to the top

Signed-off-by: str143 <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Signed-off-by: minaripenguin <[email protected]>
Signed-off-by: str143 <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Signed-off-by: str-br <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Signed-off-by: strwbrry143 <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
* add weather condition, properly configure layout paddings

Signed-off-by: str-br <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Signed-off-by: minaripenguin37 <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
* AnimatableClockView uses mIsSingleLine check whether to use double line or singleline clock
* properly align text to center

Signed-off-by: minaripenguin37 <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Signed-off-by: minaripenguin37 <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
* rework lockscreen layout
* rework AOD now playing layout
* move AOD notification shelf icons

SystemUI: Final clock revisions - follow nothingOS slice view

SystemUI: Lockscreen clock customizations

* Custom clock font customizations - credits and thanks to ghostrider-reborn for a5e6bdf305c1b7d4952ac84642249a4d1eaad0ab
* Custom clock color customization
* double-line clock format toggle/switch

SystemUI: Lockscreen clock customizations improvements

* bring back the large keyguard clock
* reevaluate system theme when applying lockscreen customization settings

SystemUI: Fix a NPE when fetching a slice item

10-29 06:27:40.846  5329  5329 E AndroidRuntime: FATAL EXCEPTION: main
10-29 06:27:40.846  5329  5329 E AndroidRuntime: Process: com.android.systemui, PID: 5329
10-29 06:27:40.846  5329  5329 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.CharSequence androidx.slice.SliceItem.getText()' on a null object reference
10-29 06:27:40.846  5329  5329 E AndroidRuntime: 	at com.android.keyguard.KeyguardSliceView.showSlice(KeyguardSliceView.java:189)
10-29 06:27:40.846  5329  5329 E AndroidRuntime: 	at com.android.keyguard.KeyguardSliceViewController.showSlice(KeyguardSliceViewController.java:222)
10-29 06:27:40.846  5329  5329 E AndroidRuntime: 	at com.android.keyguard.KeyguardSliceViewController$2.onChanged(KeyguardSliceViewController.java:91)
10-29 06:27:40.846  5329  5329 E AndroidRuntime: 	at com.android.keyguard.KeyguardSliceViewController$2.onChanged(KeyguardSliceViewController.java:87)
10-29 06:27:40.846  5329  5329 E AndroidRuntime: 	at com.android.keyguard.KeyguardSliceViewController.refresh(KeyguardSliceViewController.java:198)
10-29 06:27:40.846  5329  5329 E AndroidRuntime: 	at com.android.keyguard.KeyguardStatusViewController.dozeTimeTick(KeyguardStatusViewController.java:95)
10-29 06:27:40.846  5329  5329 E AndroidRuntime: 	at com.android.systemui.statusbar.phone.NotificationPanelViewController.onScreenTurningOn(NotificationPanelViewController.java:3574)

test: manual

Signed-off-by: minaripenguin37 <[email protected]>
Co-authored-by: hydrangea07 <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
[SuperDroidBond: Call SliceView(DateView) Fonts with separate method. It looks neat and clean]

[Good Job @eldainosor. I was confused because of sliceview shit.]
[Bootleggers (@eldainosor) edit: Update the code to use the mKeyguardSlice instead of mDateView (deprecated due to google switching all the ls date section to slices) and make a function to apply the same typeface to every view on such SliceView]
[mnri: simplify and cleanup code for rd]

Signed-off-by: SuperDroidBond <[email protected]>
Co-authored-by: minaripenguin37 <[email protected]>
Signed-off-by: minaripenguin37 <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Change-Id: Ie179a4b3fa7a1b48e473d88ee85dbe86bfedfc16
Signed-off-by: ralph950412 <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
- overall fixes for slice view changes from 24094e3ab2793922e5d1ce1584cf3f19b282581d

Signed-off-by: hydrangea07 <[email protected]>
Signed-off-by: Hưng Phan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.